New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Scholar #3093
Update Google Scholar #3093
Conversation
Hey @davidjb, thanks for taking care of this one. |
@PeterShaggyNoble Looks good and far clearer as to what it is at larger sizes than mine 👍 |
That is also what I was expecting @PeterShaggyNoble |
Did you want me to update/finish my PR with your icon, @PeterShaggyNoble? Or let you update it in the repo separately? |
I'm guessing the intention was for you to update the PR based on the |
Sure, more than happy to do it. The preview is just a PNG though - is there an svg available? |
Yeah, that was just a rough mock-up I did, @davidjb. |
f83c1c9
to
7823fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now 👍 What do you say @PeterShaggyNoble?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think, Peter will agree. :)
Perfect! 😁 Nice work, @davidjb Before we merge this in, can you update the source URL to the logos page on Wikimedia: https://commons.wikimedia.org/wiki/File:Google_Scholar_logo.svg? Nice catch on the colour, by the way. Everyone else OK with changing it to Google blue? |
7823fcd
to
bb46cf9
Compare
All done @PeterShaggyNoble, thanks for the feedback. For the URL, I'd followed the example of others' source URLs - there are several others that use the direct link to |
No problem, at some point we set guidelines on wikimedia URLs but we didn't update the existing URLs that didn't meet those guidelines. Perhaps we should... Anyway, thanks a bunch for updating the Google Scholar icon! 🎊 |
Issue: Closes #3081
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Based upon the file at https://commons.wikimedia.org/wiki/File:Google_Scholar_logo.svg with insetting applied to the mortarboard triangles and head circle segments to distinguish the parts. The hex colour has been adjusted to match the left-hand side of the coloured mortarboard, which also happens to be the colour of the Gs in the Google logo (which matches other Google brands as well).